-
-
Notifications
You must be signed in to change notification settings - Fork 35.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect error thrown when function is in comments #10929
Conversation
@Bouncey could you please explain the regex you used? A bit tough to figure out for me. |
cc @FreeCodeCamp/issue-moderators - this is ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but I can't get the branch up and running locally for some reason. Would love a confirmation from someone who can get it running that this works as it should.
@ltegman, I will test this in a few hours 👍 |
Having issue with the tests on my local setup. Don't believe it's an issue with this PR however. cc/ @FreeCodeCamp/issue-moderators, please try and review this PR! |
Unable to QA due to #11198 |
Something about the state of staging when you made your changes is what was causing problems for me. I rebased this branch against the latest staging and was able to QA just fine. LGTM 👍 |
@FreeCodeCamp/issue-moderators When merging a PR please ensure the PR actually works or does what it says. This file is no longer used anywhere and does not run actually run anywhere. |
Huh. I compared this code side by side with code that didn't have the change and saw an improvement, but it must have been something else doing it. Sorry about that! |
Pre-Submission Checklist
staging
branch of FreeCodeCamp.fix/
,feature/
, ortranslate/
(e.g.fix/signin-issue
)npm run test-challenges
. Usegit commit --amend
to amend any fixes.Type of Change
Checklist:
Description
Added new regExp in
detect-unsafe-code-stream.js
to detect if the wordfunction
is in comments and if so, ignore and do not throw the errorSyntaxError: Unsafe or unfinished function declaration